Remove the raising to high level operator within Unify Axis #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed variables we will know the right relationship.
…nd the inames in an IndexLambda.
inducer
reviewed
Nov 25, 2024
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
…ator working on an IndexLambda.
…nternal function.
inducer
reviewed
Jan 13, 2025
…g the equations and propagate that information through.
…can store the reduction string as well.
inducer
reviewed
Jan 16, 2025
| as its aggregate. | ||
| """ | ||
|
|
||
| if isinstance(expr.aggregate, prim.Variable): |
There was a problem hiding this comment.
Missing a recursion. Subscripts can contain subscripts.
| @@ -156,7 +198,7 @@ def __init__(self, tag_t: type[Tag]) -> None: | |||
|
|
|||
| # axis_to_var: mapping from (array, iaxis) to the variable to be | |||
| # used for unification. | |||
| self.axis_to_var: bidict[tuple[Array, int], str] = bidict() | |||
| self.axis_to_var: bidict[tuple[Array, int | str], str] = bidict() | |||
There was a problem hiding this comment.
It seems like you're changing what identifies an axis here. Why? How? Will this still be unique? (The answers to these questions should become documentation.)
| if isinstance(var_ind_name, prim.Variable): | ||
| lhs: str = self.get_var_for_axis(expr.bindings[vname], | ||
| axis_ind) | ||
| if IDX_LAMBDA_INAME.fullmatch(var_ind_name.name): |
There was a problem hiding this comment.
Add an else case here, to document that you've thought about it. E.g.
else:
raise AssertionError()
| for vname, set_of_ind_tuple in index_expr_used.items(): | ||
| for ind_tuple in set_of_ind_tuple: | ||
| for axis_ind, var_ind_name in enumerate(ind_tuple): | ||
| if isinstance(var_ind_name, prim.Variable): |
There was a problem hiding this comment.
Add an else case here, to document that you've thought about it. E.g.
else:
raise AssertionError()
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.